Fix observers for the interfaces. #4615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
geektoni
commented
Apr 18, 2019
geektoni
commented
- Prepend a C in front of concrete ParameterObserver classes;
- Fix printing inside ParameterObserverLogger;
geektoni
commented
Apr 18, 2019
geektoni
force-pushed
the
fix_observers_with_interfaces
branch
2 times, most recently
from
6749656
to
e5518f9
Compare
geektoni
force-pushed
the
feature/observable_framework
branch
from
5941c23
to
a23d67b
Compare
It is more consistent with Shogun's code style and it make them accessible from the SWIG interfaces (factories).
* Change %l to %lu (it was causing a segfault inside SG_PRINT); * Add a try block to catch exceptions from sg_any_dispatch;
geektoni
force-pushed
the
fix_observers_with_interfaces
branch
3 times, most recently
from
150b56e
to
fc1eead
Compare
geektoni
force-pushed
the
fix_observers_with_interfaces
branch
from
fc1eead
to
dde303e
Compare
|
This is complete now. I'll merge tomorrow @karlnapf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.